Skip to content

Kata Most frequent number#131

Open
Gioserden wants to merge 2 commits intodevelopfrom
sergio_most_frequent_number
Open

Kata Most frequent number#131
Gioserden wants to merge 2 commits intodevelopfrom
sergio_most_frequent_number

Conversation

@Gioserden
Copy link

Initial kata for frequent

@codecov-io
Copy link

codecov-io commented Aug 30, 2017

Codecov Report

Merging #131 into develop will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #131      +/-   ##
=============================================
+ Coverage      87.09%   87.27%   +0.17%     
- Complexity       416      422       +6     
=============================================
  Files             93       94       +1     
  Lines            930      943      +13     
  Branches         153      157       +4     
=============================================
+ Hits             810      823      +13     
  Misses           106      106              
  Partials          14       14
Impacted Files Coverage Δ Complexity Δ
.../org/fundacionjala/coding/sergio/MostFrequent.java 100% <100%> (ø) 6 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4b297...615d75d. Read the comment docs.

@carledriss
Copy link
Contributor

@Gioserden
It is failing with the following scenarios
java.lang.AssertionError: Should work with { 1, -13, -13, -5 }
Expected :2
Actual :1

java.lang.AssertionError: Should work for empty arrays
Expected :0
Actual :1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants